Skip to content

Fix HiFi relu for int8 #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix HiFi relu for int8 #8423

wants to merge 1 commit into from

Conversation

@mcremon-meta
Copy link
Contributor

@mcremon-meta mcremon-meta commented Feb 12, 2025

Summary: As titled.

Differential Revision: D69541729

@mcremon-meta @facebook-github-bot
Fix HiFi relu for int8
1f4905a 
Summary: As titled.

Differential Revision: D69541729
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8423

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1f4905a with merge base 1308d4d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 12, 2025

This pull request was exported from Phabricator. Differential Revision: D69541729

zonglinpeng
zonglinpeng approved these changes Feb 12, 2025
View reviewed changes
backends/cadence/hifi/operators/op_quantized_relu_out.cpp
Tensor& output) {
const uint8_t _in_zero_point = static_cast<uint8_t>(in_zero_point);
const uint8_t _out_zero_point = static_cast<uint8_t>(out_zero_point);
const int32_t _out_multiplier = static_cast<int32_t>(out_multiplier);
Copy link
Contributor

@zonglinpeng zonglinpeng Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these two need to move?

Copy link
Contributor Author

@mcremon-meta mcremon-meta Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't you're right

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcremon-meta @facebook-github-bot @zonglinpeng